Uploaded image for project: 'OpenOLAT'
  1. OpenOLAT
  2. OO-57

Editing of folders or files with wrong mime type throws red screen

    XMLWordPrintable

    Details

      Description

      How to reproduce:
      -----------------

      • in personal folder, create a folder
      • rename folder to "bla.txt"
        => system thinks that this is a text file and offers the edit link
        => pressin the edit link creates a red screen
      • upload a pdf
      • rename it to "bla.txt"
        => system thinks that this is a text file and offers the edit link
        => pressin the edit link creates a red screen

      DOD:


      • before painting the edit link, make sure it is not a directory using the VFS or File interface
      • Add necessary try/catch to all editors and show an appropriate error when the file is not what it really is
      • Do not allow online-editing of text or html files larger than 5MB to prevent DOS attacks from students (upload very large movie, rename it to txt file, OLAT will load it into RAM

      See also:
      http://bugs.olat.org/jira/browse/OLAT-5259
      http://bugs.olat.org/jira/browse/OLAT-3753

        Attachments

          Activity

            People

            Assignee:
            strentini Sergio Trentini
            Reporter:
            gnaegi Florian Gnägi
            Tester:
            Florian Gnägi
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 1 hour Original Estimate - 1 hour
                1h
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 2 hours, 11 minutes
                2h 11m