Uploaded image for project: 'OpenOLAT'
  1. OpenOLAT
  2. OO-4872

In the course elemnt "Topic assignment" a red screen is created when a topic is assigned

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 15.2.2
    • Component/s: None
    • Labels:
      None

      Description

      Steps to reproduce:

      select topic and then select the participant administration -> red screen.
      The redscreen can be reproduced at uibk-OO reliably in a particular course and course element but not with every topic.

      Problem:
      In src/main/java/org/olat/admin/securitygroup/gui/IdentitiesOfGroupTableDataModel.java in comparison to version 14.2 the resolution of the values of column 0 (Identity.name) was omitted.

      --- a/src/main/java/org/olat/admin/securitygroup/gui/IdentitiesOfGroupTableDataModel.java
      +++ b/src/main/java/org/olat/admin/securitygroup/gui/IdentitiesOfGroupTableDataModel.java
      @@ -57,13 +57,10 @@ public class IdentitiesOfGroupTableDataModel extends DefaultTableDataModel<Group
                      this.isAdministrativeUser = isAdministrativeUser;
              }
       
      -       /**
      -        * @see org.olat.core.gui.components.table.TableDataModel#getValueAt(int, int)
      -        */
      +       @Override
              public final Object getValueAt(int row, int col) {
                      GroupMemberView co = getObject(row);
                      switch(col) {
      -                       case 0: return co.getIdentity().getName();
                              case 1: return co.getOnlineStatus();
                              case 2: return co.getAddedAt();
                              default: {
      
      

      But this index is still used in the WaitingGroupController.

      DefaultColumnDescriptor cd0 = new DefaultColumnDescriptor("table.user.login", 0, COMMAND_VCARD, ureq.getLocale());
      

      Thus there is an ArrayIndexOutOfBoundsException if the following call with col = 0 occurs in the "default" of the switch statement

      UserPropertyHandler userPropertyHandler = userPropertyHandlers.get(col - 3);
      

      Suggested fix:

      diff --git a/src/main/java/org/olat/admin/securitygroup/gui/WaitingGroupController.java b/src/main/java/org/olat/admin/securitygroup/gui/WaitingGroupController.java
      index 5bf177560c..4230669e36 100644
      --- a/src/main/java/org/olat/admin/securitygroup/gui/WaitingGroupController.java
      +++ b/src/main/java/org/olat/admin/securitygroup/gui/WaitingGroupController.java
      @@ -143,13 +143,6 @@ public class WaitingGroupController extends GroupController {
              @Override
              protected void initGroupTable(TableController tableCtr, UserRequest ureq, boolean enableTablePreferences, boolean enableUserSelection) {
                      List<UserPropertyHandler> userPropertyHandlers = userManager.getUserPropertyHandlersFor(usageIdentifyer, isAdministrativeUser);
      -               // first the login name
      -               if (isAdministrativeUser) {
      -                       // first the login name, but only if administrative user
      -                       DefaultColumnDescriptor cd0 = new DefaultColumnDescriptor("table.user.login", 0, COMMAND_VCARD, ureq.getLocale());
      -                       cd0.setIsPopUpWindowAction(true, "height=700, width=900, location=no, menubar=no, resizable=yes, status=no, scrollbars=yes, toolbar=no");
      -                       tableCtr.addColumnDescriptor(cd0);
      -               }
                      if(chatEnabled) {
                              tableCtr.addColumnDescriptor(new CustomRenderColumnDescriptor("table.header.online", 1, COMMAND_IM, getLocale(),
                                              ColumnDescriptor.ALIGNMENT_LEFT, new OnlineIconRenderer()));
      
      

        Attachments

          Activity

            People

            Assignee:
            srosse Stéphane Rossé
            Reporter:
            jschindler Julia Schindler
            Tester:
            Mandy Menzel
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: