Uploaded image for project: 'OpenOLAT'
  1. OpenOLAT
  2. OO-3526

NPE in correction workflow

    XMLWordPrintable

    Details

      Description

      Somewhat possible to produce if the reviewer doesn't override the score and save the form.

      To do: harden validation of the input fields

      2018-05-23 16:49:22,033 [ajp-nio2-8044-exec-6] ERROR OLATRuntimeException - OLAT::ERROR ^%^ N44-E19 ^%^ org.olat.core.logging 
      
      https://openolat.xyz.ch/auth/RepositoryEntry/70975573/assessmentToolv2/0/BusinessGroups/0/Node/90931741563971/BusinessGroup/72253440/Node/90931741580056/Identity/72286213
      
      Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_4) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/11.1 Safari/605.1.15
      **RedScreen**
      <dispatchinfo>
      	<componentinfo>
      		<compname>ffo_main_correction_identity_assessment_item</compname>
      		<compclass>org.olat.core.gui.components.form.flexible.impl.FormWrapperContainer</compclass>
      		<extendedinfo>n/a</extendedinfo>
      		<event>
      			<class&gt;org.olat.core.gui.components.form.flexible.impl.FormEvent</class&gt;
      			<command>done</command>
      			<tostring>com:done,org.olat.core.gui.components.form.flexible.impl.FormEvent@2f23a1</tostring>
      		</event>
      	</componentinfo>
      	<controllerinfo>
      		<controllername>org.olat.ims.qti21.ui.assessment.CorrectionIdentityAssessmentItemController</controllername>
      		<controllername>org.olat.ims.qti21.ui.assessment.CorrectionIdentityAssessmentItemListController</controllername>
      		<controllername>org.olat.ims.qti21.ui.QTI21AssessmentDetailsController</controllername>
      		<controllername>org.olat.course.nodes.iq.IQIdentityListCourseNodeController</controllername>
      		<controllername>org.olat.course.assessment.ui.tool.AssessmentIdentityListCourseTreeController</controllername>
      		<controllername>org.olat.course.assessment.ui.tool.AssessedBusinessGroupCourseNodeListController</controllername>
      		<controllername>org.olat.course.assessment.ui.tool.AssessmentCourseTreeController</controllername>
      		<controllername>org.olat.course.assessment.ui.tool.AssessmentToolController</controllername>
      		<controllername>org.olat.course.run.CourseRuntimeController</controllername>
      		<controllername>org.olat.core.commons.fullWebApp.BaseFullWebappController</controllername>
      	</controllerinfo>
      </dispatchinfo>
      >>> stack of 1.cause::org.olat.core.logging.OLATRuntimeException: null
      -> at org.olat.core.gui.exception.ExceptionWindowController.<init>(ExceptionWindowController.java:116)
         at org.olat.core.gui.exception.MsgFactory.createMessageChiefController(MsgFactory.java:57)
         at org.olat.core.gui.exception.MsgFactory.createMessageChiefController(MsgFactory.java:46)
         at org.olat.core.gui.components.Window.dispatchRequest(Window.java:589)
         at org.olat.core.gui.components.Window.doDispatchRequest(Window.java:282)
         at org.olat.core.gui.components.AbstractComponent.dispatchRequest(AbstractComponent.java:193)
         at org.olat.dispatcher.AuthenticatedDispatcher.processValidDispatchURI(AuthenticatedDispatcher.java:273)
         at org.olat.dispatcher.AuthenticatedDispatcher.execute(AuthenticatedDispatcher.java:190)
         at org.olat.core.servlets.OpenOLATServlet.executeUserRequest(OpenOLATServlet.java:287)
         at org.olat.core.servlets.OpenOLATServlet.doPost(OpenOLATServlet.java:230)
         at javax.servlet.http.HttpServlet.service(HttpServlet.java:661)
      >>> stack of 2.cause::java.lang.NumberFormatException: null 
      -> at java.math.BigDecimal.<init>(BigDecimal.java:596)
         at java.math.BigDecimal.<init>(BigDecimal.java:383)
         at java.math.BigDecimal.<init>(BigDecimal.java:806)
         at org.olat.ims.qti21.ui.assessment.CorrectionIdentityInteractionsController.getManualScore(CorrectionIdentityInteractionsController.java:304)
         at org.olat.ims.qti21.ui.assessment.CorrectionIdentityAssessmentItemController.doSave(CorrectionIdentityAssessmentItemController.java:202)
         at org.olat.ims.qti21.ui.assessment.CorrectionIdentityAssessmentItemController.formInnerEvent(CorrectionIdentityAssessmentItemController.java:178)
         at org.olat.core.gui.components.form.flexible.impl.FormBasicController.event(FormBasicController.java:421)
         at org.olat.core.gui.control.DefaultController.dispatchEvent(DefaultController.java:202)
         at org.olat.core.gui.components.AbstractComponent$1.run(AbstractComponent.java:240)
         at org.olat.core.logging.activity.ThreadLocalUserActivityLoggerInstaller.runWithUserActivityLogger(ThreadLocalUserActivityLoggerInstaller.java:108)
         at org.olat.core.gui.components.AbstractComponent.fireEvent(AbstractComponent.java:238)
      

        Attachments

          Activity

            People

            • Assignee:
              srosse Stéphane Rossé
              Reporter:
              srosse Stéphane Rossé
              Tester:
              Mandy Menzel
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 35 minutes
                35m