Uploaded image for project: 'OpenOLAT'
  1. OpenOLAT
  2. OO-2936

Refactor UserManager.findIdentityKeyWithProperty to findIdentitiesWithProperty

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed (View Workflow)
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 12.0
    • Component/s: Framework
    • Labels:
      None

      Description

      The method in the class UserManager

      public Identity findIdentityKeyWithProperty(String propName, String propValue)

      returned an Identity. This is wrong in two ways: 

      • it can find multiple identities, but only the first one is returned
      • it does not return an identity key as suggested by the method name but a real identity. 

      The code is refactored to fix those two minor issues (no end user change, only internal code beautify)

      public List<Identity> findIdentitiesWithProperty(String propName, String propValue)

       

        Attachments

          Activity

            People

            Assignee:
            gnaegi Florian Gnägi
            Reporter:
            gnaegi Florian Gnägi
            Tester:
            Stéphane Rossé
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 25 minutes
                25m