Uploaded image for project: 'OpenOLAT'
  1. OpenOLAT
  2. OO-2553

Projectbroker: course owners should have the same rights as project managers

    Details

    • Type: Improvement
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 11.2.2
    • Fix Version/s: 11.2.3
    • Component/s: None
    • Labels:
      None

      Description

      In projectbroker only project managers can view the dropboxes. Course owners and administrators should have the same view on projects as the project managers. This patch fixes that:

      diff --git a/src/main/java/org/olat/course/nodes/projectbroker/ProjectFolderController.java b/src/main/java/org/olat/course/nodes/projectbroker/ProjectFolderController.java
      --- a/src/main/java/org/olat/course/nodes/projectbroker/ProjectFolderController.java
      +++ b/src/main/java/org/olat/course/nodes/projectbroker/ProjectFolderController.java
      @@ -82,9 +82,9 @@
       		ProjectBrokerModuleConfiguration moduleConfig = new ProjectBrokerModuleConfiguration(config);
       		
       		content = createVelocityContainer("folder");
      -		
      +		boolean isProjectManagerOrAdministrator = projectGroupManager.isProjectManagerOrAdministrator(ureq, userCourseEnv.getCourseEnvironment(), project);
       		if (   projectGroupManager.isProjectParticipant(ureq.getIdentity(), project)
      -			  || projectGroupManager.isProjectManagerOrAdministrator(ureq, userCourseEnv.getCourseEnvironment(), project) ) {
      +			  || isProjectManagerOrAdministrator ) {
       			content.contextPut("isParticipant", true);
       			readConfig(config);
       			if (!hasDropbox && !hasReturnbox ) {
      @@ -92,7 +92,7 @@
       				content.contextPut("noFolder", Boolean.TRUE);
       			} else {
       				getLogger().debug("isDropboxAccessible(project, moduleConfig)=" + isDropboxAccessible(project, moduleConfig));
      -				if (projectGroupManager.isProjectManager(ureq.getIdentity(), project)) {
      +				if (isProjectManagerOrAdministrator) {
       					dropboxEditController = new ProjectBrokerDropboxScoringViewController(project, ureq, wControl, courseNode, userCourseEnv); 
       					content.put("dropboxController", dropboxEditController.getInitialComponent());
       					content.contextPut("hasDropbox", Boolean.TRUE);
      @@ -108,7 +108,7 @@
       						}
       					}
       					if (hasReturnbox) {
      -						if (!projectGroupManager.isProjectManager(ureq.getIdentity(), project)) {
      +						if (!isProjectManagerOrAdministrator) {
       							returnboxController = new ProjectBrokerReturnboxController(ureq, wControl, courseNode, userCourseEnv, previewMode,project);
       							content.put("returnboxController", returnboxController.getInitialComponent());
       							content.contextPut("hasReturnbox", Boolean.TRUE);
      

        Attachments

          Activity

            People

            • Assignee:
              srosse Stéphane Rossé
              Reporter:
              stephan Stephan Clemenz
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 30 minutes
                30m