Uploaded image for project: 'OpenOLAT'
  1. OpenOLAT
  2. OO-2537

Projectbroker: RS occurs when uploading to return folder

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 11.2.1
    • Fix Version/s: 11.2.3
    • Component/s: None
    • Labels:
      None

      Description

      Under certain circumstances a RS occurs when a coach tries to upload a document to the return folder of a project broker course node:

      ERROR OLATRuntimeException  - OLAT::ERROR ^%^ N1-E59 ^%^ org.olat.core.logging ^%^ etsc4 ^%^ 131.246.246.71 ^%^ https://olat.vcrp.de/auth/RepositoryEntry/1657569333/CourseNode/93953698586863/path%3D~~agfa/0 ^%^ Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2883.87 Safari/537.36 ^%^ **RedScreen** null ::_::<dispatchinfo>	<componentinfo>		<compname>ffo_main_file_upload</compname>		<compclass>org.olat.core.gui.components.form.flexible.impl.FormWrapperContainer</compclass>		<extendedinfo>n/a</extendedinfo>		<event>			<class>org.olat.core.gui.control.Event</class>			<command>validation ok</command>			<tostring>com:validation ok,org.olat.core.gui.control.Event@d62b3f02</tostring>		</event>	</componentinfo>	<controllerinfo>		<controllername>org.olat.core.commons.modules.bc.FileUploadController</controllername>		<controllername>org.olat.core.commons.modules.bc.commands.CmdUpload</controllername>		<controllername>org.olat.core.commons.modules.bc.FolderRunController</controllername>		<controllername>org.olat.course.nodes.projectbroker.ProjectBrokerDropboxScoringViewController</controllername>		<controllername>org.olat.course.nodes.projectbroker.ProjectListController</controllername>		<controllername>org.olat.course.run.RunMainController</controllername>		<controllername>org.olat.course.run.CourseRuntimeController</controllername>		<controllername>org.olat.core.commons.fullWebApp.BaseFullWebappController</controllername>	</controllerinfo></dispatchinfo> ::_:: ^%^ >>>stack of 1.cause::org.olat.core.logging.OLATRuntimeException: null ->  at org.olat.core.gui.exception.ExceptionWindowController.<init>(ExceptionWindowController.java:116) at org.olat.core.gui.exception.MsgFactory.createMessageChiefController(MsgFactory.java:57) at org.olat.core.gui.exception.MsgFactory.createMessageChiefController(MsgFactory.java:46) at org.olat.core.gui.components.Window.dispatchRequest(Window.java:557) at org.olat.core.gui.components.Window.doDispatchRequest(Window.java:250) at org.olat.core.gui.components.AbstractComponent.dispatchRequest(AbstractComponent.java:193) at org.olat.dispatcher.AuthenticatedDispatcher.processValidDispatchURI(AuthenticatedDispatcher.java:273) at org.olat.dispatcher.AuthenticatedDispatcher.execute(AuthenticatedDispatcher.java:190) at org.olat.core.servlets.OpenOLATServlet.executeUserRequest(OpenOLATServlet.java:292) at org.olat.core.servlets.OpenOLATServlet.doPost(OpenOLATServlet.java:235) at javax.servlet.http.HttpServlet.service(HttpServlet.java:648)>>>stack of 2.cause::java.lang.NullPointerException: null ->  at org.olat.course.nodes.ta.DropboxScoringViewController.event(DropboxScoringViewController.java:337) at org.olat.core.gui.control.DefaultController$1.run(DefaultController.java:246)
      

      After applying the following patch everything is fine:

      diff --git a/src/main/java/org/olat/course/nodes/ta/DropboxScoringViewController.java b/src/main/java/org/olat/course/nodes/ta/DropboxScoringViewController.java
      --- a/src/main/java/org/olat/course/nodes/ta/DropboxScoringViewController.java
      +++ b/src/main/java/org/olat/course/nodes/ta/DropboxScoringViewController.java
      @@ -334,6 +334,9 @@
       				if(node instanceof AssessableCourseNode) {
       					AssessableCourseNode acn = (AssessableCourseNode)node;
       					AssessmentEvaluation eval = acn.getUserScoreEvaluation(userCourseEnv);
      +					if (eval == null) {
      +						eval = AssessmentEvaluation.EMPTY_EVAL;
      +					}
       					if(eval.getAssessmentStatus() == null || eval.getAssessmentStatus() == AssessmentEntryStatus.notStarted) {
       						eval = new AssessmentEvaluation(eval, AssessmentEntryStatus.inProgress);
       						acn.updateUserScoreEvaluation(eval, userCourseEnv, getIdentity(), false);
      

        Attachments

          Activity

            People

            • Assignee:
              srosse Stéphane Rossé
              Reporter:
              stephan Stephan Clemenz
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 35 minutes
                35m