Uploaded image for project: 'OpenOLAT'
  1. OpenOLAT
  2. OO-2457

Manual correction is not respected in Checklist

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 11.1.2
    • Fix Version/s: 11.2.2
    • Component/s: None
    • Labels:
      None

      Description

      In checklist course node the score evaluation is always updated even If it is configured with manual correction.

      This patch fixes that:

      diff --git a/src/main/java/org/olat/course/nodes/CheckListCourseNode.java b/src/main/java/org/olat/course/nodes/CheckListCourseNode.java
      --- a/src/main/java/org/olat/course/nodes/CheckListCourseNode.java
      +++ b/src/main/java/org/olat/course/nodes/CheckListCourseNode.java
      @@ -564,10 +564,13 @@
       		Boolean sum = (Boolean)config.get(CheckListCourseNode.CONFIG_KEY_PASSED_SUM_CHECKBOX);
       		Float cutValue = (Float)config.get(MSCourseNode.CONFIG_KEY_PASSED_CUT_VALUE);
       		Float maxScore = (Float)config.get(MSCourseNode.CONFIG_KEY_SCORE_MAX);
      -		if(cutValue != null) {
      -			doUpdateAssessment(cutValue, maxScore, userCourseEnv, assessedIdentity);
      -		} else if(sum != null) {
      -			doUpdateAssessmentBySum(userCourseEnv, assessedIdentity);
      +		Boolean manualCorrection = (Boolean)config.get(CheckListCourseNode.CONFIG_KEY_PASSED_MANUAL_CORRECTION);
      +		if (!manualCorrection) {
      +			if(cutValue != null) {
      +				doUpdateAssessment(cutValue, maxScore, userCourseEnv, assessedIdentity);
      +			} else if(sum != null) {
      +				doUpdateAssessmentBySum(userCourseEnv, assessedIdentity);
      +			}
       		}
       	}
       	
      

        Attachments

          Activity

            People

            • Assignee:
              srosse Stéphane Rossé
              Reporter:
              stephan Stephan Clemenz
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 2 hours, 40 minutes
                2h 40m