Uploaded image for project: 'OpenOLAT'
  1. OpenOLAT
  2. OO-1457

Conditional JS injection in content iFrame produces invalid HTML

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 10.0.10
    • Fix Version/s: 10.2.2
    • Component/s: Course
    • Labels:
      None

      Description

      How to repdroduce

      • Use single page element
      • In run, view source (use 'view frame source code' and not 'inspect element'
        => HTML code formatting invalid

      Inspecting the source code I found the following:

      <!--[if lt IE 9]><script type="text/javascript" src="/test7/raw/6615:313f0cea79f2/js/jquery/jquery-1.9.1.min.js")'></script><![endif]--><!--[if gte IE 9]><!--><script type="text/javascript" src="/test7/raw/6615:313f0cea79f2/js/jquery/jquery-2.1.0.min.js")'></script><!--<![endif]--><script type="text/javascript" src="/test7/raw/6615:313f0cea79f2/js/jshashtable-2.1_src.js"></script>
      <script type="text/javascript" src="/test7/raw/6615:313f0cea79f2/js/jquery/ui/jquery-ui-1.10.4.custom.min.js"></script>
      

      Problem: the jquery includes have a wrong )' at the end

      Pretty stunning that it works at all! Clever browsers..

        Attachments

          Activity

            People

            Assignee:
            gnaegi Florian Gnägi
            Reporter:
            gnaegi Florian Gnägi
            Tester:
            Stéphane Rossé
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour
                1h