Uploaded image for project: 'OpenOLAT'
  1. OpenOLAT
  2. OO-1030

iframe.js: B_ResizableColumns seems never been set

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 9.3.3
    • Fix Version/s: 9.4.0
    • Component/s: Framework
    • Labels:
      None

      Description

      When investigating some troubles with Iframes, I found out that B_ResizableColumns seems never been set in Olat. The only reference is in iframe.js.

      If I'm wrong, the following patch solves the problem, that a exception occurs when accessing mainWindow.B_ResizableColumns. The exception prevents the rest of function b_sizeIframe() being executed.

      diff -r 8d9b24c8bd51 src/main/webapp/static/js/openolat/iframe.js
      --- a/src/main/webapp/static/js/openolat/iframe.js	Fri Feb 28 16:00:47 2014 +0100
      +++ b/src/main/webapp/static/js/openolat/iframe.js	Thu Mar 20 16:53:34 2014 +0100
      @@ -89,7 +89,7 @@
       				}
       				frame.height = docHeight;
       				// Update height of menu / toolbox height in main window
      -				if(docHeight != mainWindow.b_iframe_origHeight && mainWindow.B_ResizableColumns != 'undefined') {
      +				if(docHeight != mainWindow.b_iframe_origHeight && mainWindow.B_ResizableColumns != null) {
       					//console.log("b_sizeIframe(): executing resize command on main window","iframe.js");
       					mainWindow.needsHeightAdjustment = true;
       					mainWindow.B_ResizableColumns.adjustHeight();
      

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                srosse Stéphane Rossé
                Reporter:
                stephan Stephan Clemenz
                Tester:
                Florian Gnägi
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: